]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
breakManager: Allow break to be taken or delayed when overdue
authorPhilip Withnall <pwithnall@gnome.org>
Mon, 3 Mar 2025 18:48:10 +0000 (18:48 +0000)
committerMarge Bot <marge-bot@gnome.org>
Tue, 4 Mar 2025 18:42:41 +0000 (18:42 +0000)
This makes the buttons on the ‘break overdue’ notification match those
on the ‘time to take a break’ notification. This makes more sense than
showing no buttons on the former, because it leads on from the ‘time to
take a break’ notification after a short wait.

By adding a ‘Take’ button it gives the user a path to acknowledge that
they are starting to take their break, rather than having to let the
session idle.

The ‘break overdue’ notification wasn’t on the original design[1], which is
probably why its buttons got overlooked.

[1]: https://gitlab.gnome.org/Teams/Design/settings-mockups/-/blob/master/wellbeing/wellbeing.png

Signed-off-by: Philip Withnall <pwithnall@gnome.org>
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3656>

js/misc/breakManager.js

index 6b14c2e0b14d6d20659ffef40e3c54364d918516..467a67bd70a0d4c5b1213ed5ec47f8e4c41a23e8 100644 (file)
@@ -1224,9 +1224,9 @@ class BreakNotificationSource extends GObject.Object {
                     title: _('Break Overdue'),
                     body: bodyText,
                     sound: null,
-                    allowDelay: false,
+                    allowDelay: true,
                     allowSkip: false,
-                    allowTake: false,
+                    allowTake: true,
                 });
 
                 this._scheduleUpdateState(updateTimeoutSeconds);